Hi community,
While working on carbondata we have identified some of the classes which
are not appropriate as per the java standards of programming and can be
refactored to improve code quality. We have also identified redundancy in
the written code which could be improved to enhance its readability.
Under refactoring and coding standards we will ensure some key points:
1.
Method length should not exceed 50 as it becomes less readable.
2.
Remove nested methods which are not required to be nested.
3.
Make some methods as private which are not used outside the class.
4.
Remove code redundancy within class and identify redundancy between
different modules which could further be refactored to create a common
module.
5.
Adherence to naming standards.
Major refactoring is required in the below modules:
Core
Processing
Hadoop
Integration/Hive
Integration/spark2.1
Integration/spark-common
We would like to contribute towards it by picking one module at a time.
Please provide your suggestion.
Please find below the link which contains the details of classes which can
be refactored.
https://docs.google.com/a/knoldus.in/spreadsheets/d/1ABvFfeA2KGLlchIqSe_AoNFDLfyyuGnkdRmGQ4g64yE/edit?usp=sharing
--
Regards,
Geetika Gupta
Locked
