[GitHub] NamanRastogi commented on a change in pull request #3064: [CARBONDATA-3243] Updated DOC for No-Sort Compaction and a few Fixes

[GitBox]

NamanRastogi commented on a change in pull request #3064: [CARBONDATA-3243] Updated DOC for No-Sort Compaction and a few Fixes
URL: https://github.com/apache/carbondata/pull/3064#discussion_r249434834
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SingleThreadFinalSortFilesMerger.java
 ##########
 @@ -135,8 +135,8 @@ public void addInMemoryRawResultIterator(List<RawResultIterator> sortedRawResult
               noDicAndComplexColumns, sortParameters, measureDataType);
       if (inMemorySortTempChunkHolder.hasNext()) {
         inMemorySortTempChunkHolder.readRow();
+        recordHolderHeapLocal.add(inMemorySortTempChunkHolder);
 
 Review comment:
   Yes. It is for a bug. Add the `inMemorySortTempChunkHolder` object in the priority queue only if data is present in that object. Earlier it was adding it anyway. This fixes that mistake.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services