QiangCai commented on a change in pull request #3084: [CARBONDATA-3258] Add more test case for mv datamap
URL:
https://github.com/apache/carbondata/pull/3084#discussion_r250085928
##########
File path: datamap/mv/core/src/test/scala/org/apache/carbondata/mv/rewrite/MVFunctionTest.scala
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *
http://www.apache.org/licenses/LICENSE-2.0+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.mv.rewrite
+
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.test.util.QueryTest
+import org.scalatest.BeforeAndAfterAll
+
+class MVFunctionTest extends QueryTest with BeforeAndAfterAll {
+
+
+ test("test mv no filter and query with filter") {
+ val querySQL = "select sum(age),name from main_table where name = 'tom' group by name"
+
+ sql("drop datamap if exists main_table_mv")
+ sql("drop table if exists main_table")
+ sql("create table main_table (name string,age int,height int) stored by 'carbondata'")
+ sql("insert into main_table select 'tom',20,170")
+ sql("insert into main_table select 'lily',30,160")
+ sql("create datamap main_table_mv on table main_table using 'mv' as select sum(age),name from main_table group by name")
+ sql("rebuild datamap main_table_mv")
+
+ assert(MVUtils.verifyMVDataMap(sql(querySQL).queryExecution.analyzed, "main_table_mv"))
+ checkAnswer(sql(querySQL), Seq(Row(20,"tom")))
+
+ sql("drop datamap if exists main_table_mv")
+ sql("drop table if exists main_table")
+
Review comment:
better moving create table part into the method beforeAll and move drop table part into the method afterAll
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
