[GitHub] QiangCai commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue

[GitBox]

QiangCai commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue
URL: https://github.com/apache/carbondata/pull/3096#discussion_r250083391
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortParameters.java
 ##########
 @@ -442,6 +446,8 @@ public static SortParameters createSortParameters(CarbonDataLoadConfiguration co
     parameters.setTempFileLocation(sortTempDirs);
     LOGGER.info("temp file location: " + StringUtils.join(parameters.getTempFileLocation(), ","));
 
+    parameters.setIsRangeSort(CarbonDataProcessorUtil.getSortScope(configuration)
+        == SortScopeOptions.SortScope.GLOBAL_SORT);
 
 Review comment:
   configuration.getTableSpec().getCarbonTable().getRangeColumn() != null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services