SteNicholas commented on issue #3116: [CARBONDATA-3229]Validate the true/false for all boolean parameters
URL:
https://github.com/apache/carbondata/pull/3116#issuecomment-464344531
@dhatchayani I think system is not guaranteed that whenever it is used in the code, system is checking for the validation, if validation fails system falls back to the default value defined.Therefore we still need this change.And more,I found LoadOption fillOptionWithDefaultValue method bug with "skip_empty_line" option.It shouldn't be set value by CarbonLoadOptionConstants.CARBON_OPTIONS_SKIP_EMPTY_LINE.The correct option value of "skip_empty_line" should be set by CarbonCommonConstants.CARBON_SKIP_EMPTY_LINE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
