[GitHub] ajantha-bhat commented on a change in pull request #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False.

[GitBox]

ajantha-bhat commented on a change in pull request #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False.
URL: https://github.com/apache/carbondata/pull/3070#discussion_r247767530
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/result/iterator/AbstractDetailQueryResultIterator.java
 ##########
 @@ -94,6 +94,9 @@
     if (null != batchSizeString) {
       try {
         batchSize = Integer.parseInt(batchSizeString);
+        if (0 >= batchSize) {
 
 Review comment:
   a) please make it more readable by using " batchSize <= 0"
   b) Also I feel we should not validate here.  In CarbonReaderBuilder.withBatch(0), here validate the batch size and throw exception if it is less than or equal to zero

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services