[GitHub] ajantha-bhat commented on a change in pull request #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False.

[GitBox]

ajantha-bhat commented on a change in pull request #3070: [CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False.
URL: https://github.com/apache/carbondata/pull/3070#discussion_r247768102
 
 

 ##########
 File path: store/sdk/src/test/java/org/apache/carbondata/sdk/file/ConcurrentSdkReaderTest.java
 ##########
 @@ -132,6 +132,45 @@ private void writeDataMultipleFiles(int numFiles, long numRowsPerFile) {
     }
   }
 
+  @Test public void testReadWithZeroBatchSize() throws InterruptedException {
 
 Review comment:
   No need to add a concurrent test case for this scenario.
   Add a simple test case to intercept exception when reader.withBatch(0) is called

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services