[GitHub] akashrn5 commented on a change in pull request #3121: [CARBONDATA-3287]Remove the validation for same schema in a location and fix drop datamap issue

[GitBox]

akashrn5 commented on a change in pull request #3121: [CARBONDATA-3287]Remove the validation for same schema in a location and fix drop datamap issue
URL: https://github.com/apache/carbondata/pull/3121#discussion_r254257750
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/model/QueryModel.java
 ##########
 @@ -184,7 +188,9 @@ private static CarbonMeasure getCarbonMetadataMeasure(String name, List<CarbonMe
   }
 
   private static void setDimAndMsrColumnNode(FilterProcessVO processVO, ColumnExpression col,
-      boolean[] isFilterDimensions, boolean[] isFilterMeasures) {
+      boolean[] isFilterDimensions, boolean[] isFilterMeasures, CarbonTable table) {
+    boolean isDimensionFromExpression = col.isDimension();
+    boolean isMeasureFromExpression = col.isMeasure();
 
 Review comment:
   initially it will have all the flags, dimension or measure, but we do reset and again find the corresponding dimension or measure and set it back, so im taking the flags before reset, to make the desicion at later part

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services