akashrn5 commented on a change in pull request #3129: [CARBONDATA-3295] Fix that MV datamap throw exception because its rewrite algorithm when query SQL has multiply subquery
URL:
https://github.com/apache/carbondata/pull/3129#discussion_r257600892
##########
File path: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/basicOperators.scala
##########
@@ -39,6 +39,21 @@ case class GroupBy(
flagSpec: Seq[Seq[Any]],
dataMapTableRelation: Option[ModularPlan] = None) extends UnaryNode with Matchable {
override def output: Seq[Attribute] = outputList.map(_.toAttribute)
+
Review comment:
please add comments, same applicable for next one more method also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services