[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3475: [WIP] Optimize getSplits() during compaction

[GitBox]

Indhumathi27 commented on a change in pull request #3475: [WIP] Optimize getSplits() during compaction
URL: https://github.com/apache/carbondata/pull/3475#discussion_r349926548
 
 

 ##########
 File path: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
 ##########
 @@ -359,6 +359,8 @@ class CarbonMergerRDD[K, V](
       loadMetadataDetails = SegmentStatusManager
         .readLoadMetadata(CarbonTablePath.getMetadataPath(tablePath))
     }
+
+    val validSegIds: java.util.List[String] = new util.ArrayList[String]()
     // for each valid segment.
     for (eachSeg <- carbonMergerMapping.validSegments) {
       // In case of range column get the size for calculation of number of ranges
 
 Review comment:
   `if(null != rangeColumn)` check is for calculating the total size for range column based on valid segments in the loop. so, i think it cannot be optimized further

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services