[GitHub] [carbondata] Indhumathi27 opened a new pull request #3699: [WIP] Fix query not hitting mv without alias, with mv having Alias

[GitBox]

Indhumathi27 opened a new pull request #3699: [WIP] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699
 
 
    ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3699: [WIP] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-610942587
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2684/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-610958944
 
 
   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/972/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Indhumathi27 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-610966619
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-611050222
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/976/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-611053358
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2688/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Indhumathi27 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-612763417
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on a change in pull request #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#discussion_r407336441
 
 

 ##########
 File path: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/MVMatcher.scala
 ##########
 @@ -863,11 +863,15 @@ private object GroupbyGroupbyNoChildDelta extends MVMatchPattern {
           isExpressionMatches(expr, gb_2q.predicateList))
         val isOutputEmR = gb_2q.outputList.forall {
           case a @ Alias(_, _) =>
-            gb_2a.outputList.exists{
+            gb_2a.outputList.exists {
               case a1: Alias => a1.child.semanticEquals(a.child)
 
 Review comment:
   rename `a1` as `alias`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on a change in pull request #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#discussion_r407336463
 
 

 ##########
 File path: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/MVMatcher.scala
 ##########
 @@ -863,11 +863,15 @@ private object GroupbyGroupbyNoChildDelta extends MVMatchPattern {
           isExpressionMatches(expr, gb_2q.predicateList))
         val isOutputEmR = gb_2q.outputList.forall {
           case a @ Alias(_, _) =>
-            gb_2a.outputList.exists{
+            gb_2a.outputList.exists {
               case a1: Alias => a1.child.semanticEquals(a.child)
               case exp => exp.semanticEquals(a.child)
             }
-          case exp => gb_2a.outputList.exists(_.semanticEquals(exp))
+          case exp =>
+            gb_2a.outputList.exists {
+              case a1: Alias => a1.child.semanticEquals(exp)
 
 Review comment:
   rename `a1` as `alias`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-612795898
 
 
   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1004/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-612802869
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2716/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Indhumathi27 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-612813014
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-612862033
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2721/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-612862084
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1009/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on issue #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699#issuecomment-613229133
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3699: [CARBONDATA-3768] Fix query not hitting mv without alias, with mv having Alias
URL: https://github.com/apache/carbondata/pull/3699
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services