[GitHub] [carbondata] Indhumathi27 opened a new pull request #3735: [HOTFIX] Fix spelling, link and ddl in SI and MV Documentation

[GitBox]

akashrn5 commented on a change in pull request #3735:
URL: https://github.com/apache/carbondata/pull/3735#discussion_r420557886



##########
File path: docs/mv-guide.md
##########
@@ -207,15 +207,15 @@
       materialized view, if not, the operation is allowed, otherwise operation will be rejected by
       throwing exception.
    3. Partition management command: `ALTER TABLE ADD/DROP PARTITION`. Note that dropping a partition
-      will be allowed only if partition is participating in all indexes associated with fact table.
+      will be allowed only if the partition is participating in all materialized views associated with fact table.

Review comment:
       ```suggestion
         will be allowed only if the partition columns of fact table is participating in all of the table's materialized views.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on a change in pull request #3735:
URL: https://github.com/apache/carbondata/pull/3735#discussion_r420605411



##########
File path: docs/mv-guide.md
##########
@@ -207,15 +207,15 @@
       materialized view, if not, the operation is allowed, otherwise operation will be rejected by
       throwing exception.
    3. Partition management command: `ALTER TABLE ADD/DROP PARTITION`. Note that dropping a partition
-      will be allowed only if partition is participating in all indexes associated with fact table.
+      will be allowed only if the partition is participating in all materialized views associated with fact table.

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on pull request #3735:
URL: https://github.com/apache/carbondata/pull/3735#issuecomment-624523437


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3735:
URL: https://github.com/apache/carbondata/pull/3735#issuecomment-624557132


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1228/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3735:
URL: https://github.com/apache/carbondata/pull/3735#issuecomment-624558447


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2946/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]