[GitHub] [carbondata] Indhumathi27 opened a new pull request #3955: [WIP] Fix SubQuery not hitting mv

[GitBox]

Indhumathi27 opened a new pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955


    ### Why is this PR needed?
   
   If a MV having aggregation, is created with all columns present in main table, then some sub-queries are not hitting mv.
   
    ### What changes were proposed in this PR?
   1. When all columns are given in projection in a aggregate query, logical plan will not have Project node. Added Project node to logical plan in this case, to match subqueries also to mv.
   2. In GroupByGroupByNochildData pattern, added check for checking CAST(aggregate expression) and used group by result to get final compensation result
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698525365


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2462/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698527204


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4205/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on a change in pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#discussion_r494792185



##########
File path: mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/Modularizer.scala
##########
@@ -66,6 +68,22 @@ abstract class Modularizer[TreeType <: TreeNode[TreeType]] {
     makeupAliasMappings(mplans)
   }
 
+  private def transformPlan(plan: LogicalPlan) = {

Review comment:
       please change the method name to something meaningful according to functionality




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698827074


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4211/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698828029


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698828553


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2468/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698877603


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2472/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698877773


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4215/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698900334


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698525365






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698828029


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#issuecomment-698900334


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on a change in pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955#discussion_r494792185



##########
File path: mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/Modularizer.scala
##########
@@ -66,6 +68,22 @@ abstract class Modularizer[TreeType <: TreeNode[TreeType]] {
     makeupAliasMappings(mplans)
   }
 
+  private def transformPlan(plan: LogicalPlan) = {

Review comment:
       please change the method name to something meaningful according to functionality




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

asfgit closed pull request #3955:
URL: https://github.com/apache/carbondata/pull/3955


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]