[GitHub] [carbondata] Indhumathi27 opened a new pull request #4091: [WIP] Fix Refresh MV which does not exist error message

classic Classic list List threaded Threaded
21 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 opened a new pull request #4091: [WIP] Fix Refresh MV which does not exist error message

GitBox

Indhumathi27 opened a new pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091


    ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [WIP] Fix Refresh MV which does not exist error message

GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-775723987


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5442/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [WIP] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-775728978


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3681/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-777596298


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3311/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-777601640


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5069/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] brijoobopanna commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

brijoobopanna commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-778194529


   retest this please
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-778247911






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

akashrn5 commented on a change in pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#discussion_r576105735



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
##########
@@ -117,6 +115,8 @@ case class CarbonDropTableCommand(
         viewDropCommands.foreach(_.processMetadata(sparkSession))
       }
 
+      CarbonEnv.getInstance(sparkSession).carbonMetaStore.dropTable(identifier)(sparkSession)

Review comment:
       add a comment here, whatever has been added in the PR description, so that later someone shouldn't change it back.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-779237342


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3704/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-779238126


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5469/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

akashrn5 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-779619403


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

akashrn5 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-780437251


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-780491628






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

Indhumathi27 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-780497167


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-780543770






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

Indhumathi27 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-780563734


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-780624830


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3718/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-780630691


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5482/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 removed a comment on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

akashrn5 removed a comment on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-779619403


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on pull request #4091: [CARBONDATA-4124] Fix Refresh MV which does not exist error message

GitBox
In reply to this post by GitBox

akashrn5 commented on pull request #4091:
URL: https://github.com/apache/carbondata/pull/4091#issuecomment-780642185


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


12