KanakaKumar commented on a change in pull request #3181: [CARBONDATA-3356] Support decimal for json schema and Provide better exception for users to solve problem when carbonData DataSource read SDK files with varchar
URL:
https://github.com/apache/carbondata/pull/3181#discussion_r292780517
##########
File path: integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala
##########
@@ -1779,7 +1858,7 @@ class SparkCarbonDataSourceTest extends FunSuite with BeforeAndAfterAll {
assert(ex.getMessage.contains("column: abc specified in inverted index columns does not exist in schema"))
}
- var writerPath = new File(this.getClass.getResource("/").getPath
+ var WriterOutputPath = new File(this.getClass.getResource("/").getPath
Review comment:
why to change the variable name?
usually variable names should start with smallcase. Please correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services