[GitHub] [carbondata] KanakaKumar commented on a change in pull request #3188: [CARBONDATA-3358] Support configurable decode for loading binary data, support base64 and Hex decode.

[GitBox]

KanakaKumar commented on a change in pull request #3188: [CARBONDATA-3358] Support configurable decode for loading binary data, support base64 and Hex decode.
URL: https://github.com/apache/carbondata/pull/3188#discussion_r283656563
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java
 ##########
 @@ -426,6 +432,24 @@ private void validateAndSetColumnCompressor(CarbonLoadModel carbonLoadModel)
     }
   }
 
+
+  private void validateAndSetBinaryDecoder(CarbonLoadModel carbonLoadModel)
+      throws InvalidLoadOptionException {
+    try {
+      String binaryDecoder = carbonLoadModel.getBinaryDecoder();
+      if (StringUtils.isBlank(binaryDecoder)) {
 
 Review comment:
   No need to set default as current default is empty decoder.
   If the configured binaryDecoder is non empty, then validate with allowed values "hex", "base64"
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services