[GitHub] [carbondata] KanakaKumar commented on a change in pull request #3221: [CARBONDATA-3386] Concurrent Merge index and query is failing

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] KanakaKumar commented on a change in pull request #3221: [CARBONDATA-3386] Concurrent Merge index and query is failing

GitBox
KanakaKumar commented on a change in pull request #3221: [CARBONDATA-3386] Concurrent Merge index and query is failing
URL: https://github.com/apache/carbondata/pull/3221#discussion_r284284997
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
 ##########
 @@ -512,17 +513,12 @@ object CarbonDataRDDFactory {
 
       writeDictionary(carbonLoadModel, result, writeAll = false)
 
+      MergeIndexUtil.mergeIndexFilesOnLoad(carbonLoadModel, sqlContext.sparkSession)
+
       val segmentFileName =
         SegmentFileStore.writeSegmentFile(carbonTable, carbonLoadModel.getSegmentId,
           String.valueOf(carbonLoadModel.getFactTimeStamp))
 
-      SegmentFileStore.updateSegmentFile(
 
 Review comment:
   I think we can keep it back to avoid unknown impact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services