[GitHub] [carbondata] KanakaKumar commented on a change in pull request #3271: [CARBONDATA-3423] Validate dictionary for binary data type

[GitBox]

KanakaKumar commented on a change in pull request #3271: [CARBONDATA-3423] Validate dictionary for binary data type
URL: https://github.com/apache/carbondata/pull/3271#discussion_r292768379
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/binary/TestBinaryDataType.scala
 ##########
 @@ -158,6 +158,63 @@ class TestBinaryDataType extends QueryTest with BeforeAndAfterAll {
         assert(true)
     }
 
+
+    test("Unsupport DICTIONARY_INCLUDE for binary") {
+
+        sql("DROP TABLE IF EXISTS binaryTable")
+        val exception = intercept[MalformedCarbonCommandException] {
+            sql(
+                """
+                  | CREATE TABLE binaryTable(
+                  |     id int,
+                  |     name string,
+                  |     city string,
+                  |     age int,
+                  |     binaryField binary)
+                  | STORED BY 'carbondata'
+                  | tblproperties('dictionary_enable'='true','dictionary_include'='binaryField')
 
 Review comment:
   dictionary_enable is not a supported table property, please remove.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services