[GitHub] [carbondata] KanakaKumar commented on a change in pull request #3300: [CARBONDATA-3445] Aggregate query empty list error fix.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] KanakaKumar commented on a change in pull request #3300: [CARBONDATA-3445] Aggregate query empty list error fix.

GitBox
KanakaKumar commented on a change in pull request #3300: [CARBONDATA-3445] Aggregate query empty list error fix.
URL: https://github.com/apache/carbondata/pull/3300#discussion_r295634428
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonCatalystOperators.scala
 ##########
 @@ -179,6 +179,9 @@ object CountStarPlan {
     if (groupingExpressions.nonEmpty) {
       return false
     }
+    if (partialComputation.isEmpty) {
 
 Review comment:
   Please add  UT if possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services