[GitHub] [carbondata] Karan980 opened a new pull request #3857: [CARBONDATA-3914] Fixed issue on reading data from carbon table through hive beeline when no data is present in table.

[GitBox]

Karan980 opened a new pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857


   **Why is this PR needed?**
   Reading data from empty carbontable through hive beeline was giving "Unable read Carbon    Schema" exception, when no data is present in table.
       
   **What changes were proposed in this PR?**
       
   **Does this PR introduce any user interface change?**
   No
       
   **Is any new testcase added?**
   No
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-662073114


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-662384120


   add to whitelist


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-662442472


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3467/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-662443929


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1725/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Karan980 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-662888698


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-662943123


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3477/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-662947710


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1735/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-663573168


   @Karan980 please refer other PRs and update the PR description in a similar way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Karan980 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-663601554


   @akashrn5 Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on a change in pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#discussion_r460677188



##########
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##########
@@ -2137,7 +2138,7 @@ public static String getFilePathExternalFilePath(String path, Configuration conf
     if (fistFilePath == null) {
       // Check if we can infer the schema from the hive metastore.
       LOGGER.error("CarbonData file is not present in the table location");
-      throw new IOException("CarbonData file is not present in the table location");
+      throw new FileNotFoundException("CarbonData file is not present in the table location");

Review comment:
       @Karan980 , the inferSchema is called from many places, basically can you check and  confirm from the code that, when you throw the FileNotFoundException, the exception is properly handled from all the callers or callers of caller and confirm no where the exception will be hidden due to this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on a change in pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#discussion_r460677188



##########
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##########
@@ -2137,7 +2138,7 @@ public static String getFilePathExternalFilePath(String path, Configuration conf
     if (fistFilePath == null) {
       // Check if we can infer the schema from the hive metastore.
       LOGGER.error("CarbonData file is not present in the table location");
-      throw new IOException("CarbonData file is not present in the table location");
+      throw new FileNotFoundException("CarbonData file is not present in the table location");

Review comment:
       @Karan980 , the `inferSchema ` is called from many places, basically can you check and  confirm from the code that, when you throw the `FileNotFoundException`, the exception is properly handled from all the callers or callers of caller and confirm no where the exception will be hidden due to this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

VenuReddy2103 commented on a change in pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#discussion_r461385726



##########
File path: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
##########
@@ -116,7 +117,10 @@ private static CarbonTable getCarbonTable(Configuration configuration, String pa
     try {
       carbonTable = getCarbonTable(jobContext.getConfiguration(),
           jobContext.getConfiguration().get(hive_metastoreConstants.META_TABLE_LOCATION));
-    } catch (Exception e) {
+    } catch (FileNotFoundException e) {
+      return new InputSplit[0];
+    }
+    catch (Exception e) {

Review comment:
       formatting issue. Suggest to move it to previous line.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

asfgit closed pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-664777049






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-664827883






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Karan980 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-664850764


   @VenuReddy2103 Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

VenuReddy2103 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-665140464


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]