[GitHub] [carbondata] MarvinLitt commented on a change in pull request #3294: [CARBONDATA-3462][DOC]Added documentation for index server

[GitBox]

MarvinLitt commented on a change in pull request #3294: [CARBONDATA-3462][DOC]Added documentation for index server
URL: https://github.com/apache/carbondata/pull/3294#discussion_r304752043
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/indexserver/IndexServer.scala
 ##########
 @@ -178,6 +171,8 @@ object IndexServer extends ServerInterface {
           server.stop()
         }
       })
+      CarbonProperties.getInstance().addProperty(CarbonCommonConstants
+        .CARBON_ENABLE_INDEX_SERVER, "true")
       LOGGER.info(s"Index cache server running on ${ server.getPort } port")
 
 Review comment:
   it is better check both ip and port. if one does not define "carbon.index.server.port" then there may be error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services