[GitHub] [carbondata] Nitin-Kashyap commented on a change in pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

[GitBox]

Nitin-Kashyap commented on a change in pull request #3818:
URL: https://github.com/apache/carbondata/pull/3818#discussion_r457520179



##########
File path: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonColumnVectorWrapper.java
##########
@@ -273,7 +279,7 @@ public boolean hasDictionary() {
 
   @Override
   public CarbonColumnVector getDictionaryVector() {
-    return this.columnVector.getDictionaryVector();
+    return this.dictionaryVectorWrapper;

Review comment:
       Thanks for the review.
   JIRA issue I created had insert and delete carried out using spark integration; and read using presto integration.
   
   I'm not sure about the applicability part, I trust the contributes and maintainers wisdom in here :)
   However, I observed the case while my local verification and suggested the fix after verification.
   Feel free to use or reject.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]