[GitHub] [carbondata] Nitin-Kashyap commented on a change in pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

[GitBox]

Nitin-Kashyap commented on a change in pull request #3818:
URL: https://github.com/apache/carbondata/pull/3818#discussion_r457523394



##########
File path: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonColumnVectorWrapper.java
##########
@@ -273,7 +279,7 @@ public boolean hasDictionary() {
 
   @Override
   public CarbonColumnVector getDictionaryVector() {
-    return this.columnVector.getDictionaryVector();
+    return this.dictionaryVectorWrapper;

Review comment:
       I reviewed the `SliceStreamReader::buildBlock`, I dont see how it can filter out the deleted record when `carbon.push.rowfilters.for.vector=true` property is set.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]