[GitHub] [carbondata] Nitin-Kashyap commented on pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Nitin-Kashyap commented on pull request #3818: [Carbondata-3883] Added filtering for the deleted rows for local dictionary fields

GitBox

Nitin-Kashyap commented on pull request #3818:
URL: https://github.com/apache/carbondata/pull/3818#issuecomment-661134146


   > @Nitin-Kashyap : Can you please add a test here in `PrestoAllDataTypeLocalDictTest.scala` for this scenario. May be just add one more query for existing table local dictionary column that can cause this problem.
   
   Since the test step required me to insert and delete record using Spark-Integration; The same feature is unavailable in Presto-Integration; I'm not sure how to add the same in `PrestoAllDataTypeLocalDictTest.scala`.
   
   Please suggest, I would be happy to add!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]