[GitHub] [carbondata] QiangCai commented on a change in pull request #3183: [CARBONDATA-3349] Show sort_columns for each segment

[GitBox]

QiangCai commented on a change in pull request #3183: [CARBONDATA-3349] Show sort_columns for each segment
URL: https://github.com/apache/carbondata/pull/3183#discussion_r279174330
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonShowLoadsCommand.scala
 ##########
 @@ -52,7 +54,9 @@ case class CarbonShowLoadsCommand(
         AttributeReference("Merged To", StringType, nullable = false)(),
         AttributeReference("File Format", StringType, nullable = false)(),
         AttributeReference("Data Size", StringType, nullable = false)(),
-        AttributeReference("Index Size", StringType, nullable = false)())
+        AttributeReference("Index Size", StringType, nullable = false)(),
+        AttributeReference("Is Sorted", StringType, nullable = false)(),
+        AttributeReference("Sort Columns", StringType, nullable = true)())
 
 Review comment:
   2. in the segment, we lost the sort_scope information.
   1. is_sorted has 3 options( true, false, NA),  but we always can get sort_columns from the schema in the index.  Sort_columns will show columns only when the is_sorted is true.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services