[GitHub] [carbondata] QiangCai commented on a change in pull request #3366: [CARBONDATA-3497] Support to write long string for streaming table

[GitBox]

QiangCai commented on a change in pull request #3366: [CARBONDATA-3497] Support to write long string for streaming table
URL: https://github.com/apache/carbondata/pull/3366#discussion_r319334485
 
 

 ##########
 File path: hadoop/src/main/java/org/apache/carbondata/hadoop/stream/StreamRecordReader.java
 ##########
 @@ -387,7 +392,12 @@ protected void readRowFromStream() {
         }
       } else {
         if (isNoDictColumn[colCount]) {
-          int v = input.readShort();
+          int v = 0;
+          if (dimensionDataTypes[colCount] == DataTypes.VARCHAR) {
 
 Review comment:
   better to use a boolean array to store the result.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services