[GitHub] [carbondata] QiangCai commented on a change in pull request #3389: [CARBONDATA-3524] Support global_sort compaction

[GitBox]

QiangCai commented on a change in pull request #3389: [CARBONDATA-3524] Support global_sort compaction
URL: https://github.com/apache/carbondata/pull/3389#discussion_r329343403
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CompactionSupportGlobalSortFunctionTest.scala
 ##########
 @@ -503,7 +514,7 @@ class CompactionSupportGlobalSortFunctionTest extends QueryTest with BeforeAndAf
       """
         | CREATE TABLE compaction_globalsort2(id INT, name STRING, city STRING, age INT)
         | STORED BY 'org.apache.carbondata.format'
-        |  TBLPROPERTIES('SORT_COLUMNS'='id','SORT_SCOPE'='GLOBAL_SORT')
+        |  TBLPROPERTIES('SORT_COLUMNS'='id','SORT_SCOPE'='GLOBAL_SORT', 'global_sort_partitions'='1')
 
 Review comment:
   global_sort need this configuration

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services