[GitHub] [carbondata] QiangCai commented on a change in pull request #3389: [CARBONDATA-3524] Support global_sort compaction

[GitBox]

QiangCai commented on a change in pull request #3389: [CARBONDATA-3524] Support global_sort compaction
URL: https://github.com/apache/carbondata/pull/3389#discussion_r329343823
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala
 ##########
 @@ -195,6 +204,11 @@ class CarbonTableCompactor(carbonLoadModel: CarbonLoadModel,
           carbonLoadModel,
           carbonMergerMapping
         ).collect
+      } else if (SortScope.GLOBAL_SORT == carbonTable.getSortScope &&
+                 !carbonTable.getSortColumns.isEmpty &&
+                 carbonTable.getRangeColumn == null &&
 
 Review comment:
   Avoid impacting Range_column feature.
   Because range_column has a different flow for loading and compaction.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services