[GitHub] [carbondata] QiangCai commented on a change in pull request #3411: [WIP] Fix NPE in multi-thread pruning on NonTransactional tables

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai commented on a change in pull request #3411: [WIP] Fix NPE in multi-thread pruning on NonTransactional tables

GitBox
QiangCai commented on a change in pull request #3411: [WIP] Fix NPE in multi-thread pruning on NonTransactional tables
URL: https://github.com/apache/carbondata/pull/3411#discussion_r336340540
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java
 ##########
 @@ -167,8 +167,9 @@ public CarbonTable getTable() {
         }
       } else {
         for (DataMap dataMap : dataMaps.get(segment)) {
+          // TODO: just for test will be reverted back after test
           pruneBlocklets.addAll(
-              dataMap.prune(filter.getExpression(), segmentProperties, partitions, table));
+              dataMap.prune(filter.getNewCopyOfExpression(), segmentProperties, partitions, table));
 
 Review comment:
   please revert to old code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services