QiangCai commented on a change in pull request #3502: [CARBONATA-3605] Remove global dictionary feature
URL:
https://github.com/apache/carbondata/pull/3502#discussion_r361786862
##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java
##########
@@ -77,7 +76,6 @@ public ColumnPageEncoder createEncoder(TableSpec.ColumnSpec columnSpec, ColumnPa
private ColumnPageEncoder createEncoderForDimension(TableSpec.DimensionSpec columnSpec,
ColumnPage inputPage) {
switch (columnSpec.getColumnType()) {
- case GLOBAL_DICTIONARY:
case DIRECT_DICTIONARY:
Review comment:
can we use a new name instead of DIRECT_DICTIONARY?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
