[GitHub] [carbondata] QiangCai opened a new pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)

[GitBox]

QiangCai opened a new pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586
 
 
    ### Why is this PR needed?
    Considering back-compatibility,  CarbonSession should use old flow (not CarbonExtensions flow)
   
    ### What changes were proposed in this PR?
   1. Remove CarbonExtension from CarbonSession
   2. Recover CarbonSessionCatalog
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

zzcclp commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#discussion_r368450926
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
 ##########
 @@ -50,7 +48,7 @@ object CarbonThriftServer {
     val builder = SparkSession
 
 Review comment:
   the 'storePath' parameter is not required, can remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-576195173
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1702/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#discussion_r368788562
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
 ##########
 @@ -50,7 +48,7 @@ object CarbonThriftServer {
     val builder = SparkSession
 
 Review comment:
   fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-576504900
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1709/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

zzcclp commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-577214329
 
 
   please rebase master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-581264552
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/5/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-581789959
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/144/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-581814754
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1848/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#discussion_r374654461
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
 ##########
 @@ -28,70 +28,63 @@ import org.apache.carbondata.common.logging.LogServiceFactory
 import org.apache.carbondata.core.util.CarbonProperties
 import org.apache.carbondata.spark.util.CarbonSparkUtil
 
- /**
-  * CarbonThriftServer support different modes:
-  * 1. read/write data from/to HDFS or local,it only needs configurate storePath
-  * 2. read/write data from/to S3, it needs provide access-key, secret-key, s3-endpoint
-  */
+/**
+ * CarbonThriftServer support different modes:
+ * 1. read/write data from/to HDFS or local, no need parameters
 
 Review comment:
   ```suggestion
    * 1. read/write data from/to HDFS or local, no parameter is required in this case
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#discussion_r374654830
 
 

 ##########
 File path: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala
 ##########
 @@ -40,11 +40,18 @@ object CarbonSessionExample {
       .addProperty(CarbonCommonConstants.ENABLE_QUERY_STATISTICS, "false")
     val spark = ExampleUtils.createCarbonSession("CarbonSessionExample")
     spark.sparkContext.setLogLevel("error")
-    exampleBody(spark)
+    Seq(
+      "stored as carbondata",
+      "using carbondata",
+      "stored by 'carbondata'",
 
 Review comment:
   Is it still supported?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#discussion_r374654830
 
 

 ##########
 File path: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala
 ##########
 @@ -40,11 +40,18 @@ object CarbonSessionExample {
       .addProperty(CarbonCommonConstants.ENABLE_QUERY_STATISTICS, "false")
     val spark = ExampleUtils.createCarbonSession("CarbonSessionExample")
     spark.sparkContext.setLogLevel("error")
-    exampleBody(spark)
+    Seq(
+      "stored as carbondata",
+      "using carbondata",
+      "stored by 'carbondata'",
 
 Review comment:
   Is it still supported? I though it is not supported anymore

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#discussion_r375016751
 
 

 ##########
 File path: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala
 ##########
 @@ -40,11 +40,18 @@ object CarbonSessionExample {
       .addProperty(CarbonCommonConstants.ENABLE_QUERY_STATISTICS, "false")
     val spark = ExampleUtils.createCarbonSession("CarbonSessionExample")
     spark.sparkContext.setLogLevel("error")
-    exampleBody(spark)
+    Seq(
+      "stored as carbondata",
+      "using carbondata",
+      "stored by 'carbondata'",
 
 Review comment:
   yes, CarbonSession will keep all old features.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-582200949
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/149/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-582216585
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1853/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-582480688
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-582688766
 
 
   I will raise another PR to fix the ci issue for spark 2.4

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services