[GitHub] [carbondata] QiangCai opened a new pull request #3863: [CARBONDATA-3924] Add default dynamic parameters only one time in a JVM process

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai opened a new pull request #3863: [CARBONDATA-3924] Add default dynamic parameters only one time in a JVM process

GitBox

QiangCai opened a new pull request #3863:
URL: https://github.com/apache/carbondata/pull/3863


    ### Why is this PR needed?
    PR#3805 introduces a problem that the system will add default dynamic parameters many times in a JVM process at concurrent query case.
   If ConfigEntry.registerEntry method registers an exists entry again, it will throw exception.
   
    ### What changes were proposed in this PR?
   Invoking CarbonSQLConf.addDefaultParams only one time in a JVM process
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on pull request #3863: [CARBONDATA-3924] Add default dynamic parameters only one time in a JVM process

GitBox

ajantha-bhat commented on pull request #3863:
URL: https://github.com/apache/carbondata/pull/3863#issuecomment-664184155


   LGTM.
   can merge once build passes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3863: [CARBONDATA-3924] Add default dynamic parameters only one time in a JVM process

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3863:
URL: https://github.com/apache/carbondata/pull/3863#issuecomment-664244778


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1758/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3863: [CARBONDATA-3924] Add default dynamic parameters only one time in a JVM process

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3863:
URL: https://github.com/apache/carbondata/pull/3863#issuecomment-664251374


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3500/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on pull request #3863: [CARBONDATA-3924] Add default dynamic parameters only one time in a JVM process

GitBox
In reply to this post by GitBox

ajantha-bhat commented on pull request #3863:
URL: https://github.com/apache/carbondata/pull/3863#issuecomment-664257717


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]