[GitHub] [carbondata] ShreelekhyaG opened a new pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ShreelekhyaG opened a new pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox

ShreelekhyaG opened a new pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084


    ### Why is this PR needed?
    When `carbon.read.partition.hive.direct` is `false` then select queries on partition table result is invalid .
   For a single partition, partition values are appended to form the wrong path when loaded by the same segment.
   Ex: For partition on column `b`, path: `/tablepath/b=1/b=2`
   
    ### What changes were proposed in this PR?
   In `PartitionCacheManager`,  changes made to handle single and multiple partitions. Encoded the URI path to handle space values in the string.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox

CarbonDataQA2 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-769020831


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3614/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-769022572


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5374/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771412881


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771459205


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3642/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771465576


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5402/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ShreelekhyaG commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

ShreelekhyaG commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771481950


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771547087


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5407/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771547238


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3647/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771559408


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

asfgit closed pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771412881






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771459205






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ShreelekhyaG commented on pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

ShreelekhyaG commented on pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084#issuecomment-771481950


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #4084: [CARBONDATA-4113] Partition prune and cache fix when carbon.read.partition.hive.direct is disabled.

GitBox
In reply to this post by GitBox

asfgit closed pull request #4084:
URL: https://github.com/apache/carbondata/pull/4084


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]