Login  Register

[GitHub] [carbondata] Sunt-ing opened a new pull request #4136: [Doc] Update how-to-contribute-to-apache-carbondata.md: syntax and format issues

classic Classic list List threaded Threaded
31 messages Options Options
Embed post
Permalink
12
Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox

CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853747798


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3739/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

Indhumathi27 commented on a change in pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#discussion_r644724776



##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -189,4 +189,4 @@ From another local branch, run:
 $ git fetch --all
 $ git branch -d <my-branch>
 $ git push <GitHub_user> --delete <my-branch>
-```
\ No newline at end of file
+```

Review comment:
       Looks like it is not reverted




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] Sunt-ing commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

Sunt-ing commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853821655


   Sorry for the long-time bother, but I do think it should be fine now.  @Indhumathi27


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853882754






--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] Indhumathi27 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

Indhumathi27 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-854413455


   LGTM. Thankyou for your contribution.


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] asfgit closed pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

asfgit closed pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853746591






--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

Indhumathi27 commented on a change in pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#discussion_r644504897



##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -7,7 +7,7 @@
     the License.  You may obtain a copy of the License at
 
       http://www.apache.org/licenses/LICENSE-2.0
-
+    

Review comment:
       Please rever this change

##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -189,4 +189,4 @@ From another local branch, run:
 $ git fetch --all
 $ git branch -d <my-branch>
 $ git push <GitHub_user> --delete <my-branch>
-```
\ No newline at end of file
+```

Review comment:
       Looks like it is not reverted




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] Sunt-ing commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

Sunt-ing commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-853682436






--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] Indhumathi27 commented on pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

Indhumathi27 commented on pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136#issuecomment-854413455


   LGTM. Thankyou for your contribution.


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
| More
Print post
Permalink

[GitHub] [carbondata] asfgit closed pull request #4136: [Doc] syntax and format issues in README.md and how-to-contribute-to-apache-carbondata.md

GitBox
In reply to this post by GitBox

asfgit closed pull request #4136:
URL: https://github.com/apache/carbondata/pull/4136


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


12