[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

[GitBox]

VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#discussion_r349535716
 
 

 ##########
 File path: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
 ##########
 @@ -218,6 +220,45 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
     )
   }
 
+  def getField(col: StructField): Field = {
+    var columnComment: String = ""
+    var plainComment: String = ""
+    if (col.getComment().isDefined) {
+      columnComment = " comment \"" + col.getComment().get + "\""
+      plainComment = col.getComment().get
+    }
+    val x =
+      if (col.dataType.catalogString == "float") {
 
 Review comment:
   This code is moved from `getFields` method of `CarbonSpark2SqlParser.scala` and made it as reusable method. So that it can be called for newly created column as well. It is done to avoid code duplication.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services