[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

[GitBox]

VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#discussion_r349878261
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/RowConverterImpl.java
 ##########
 @@ -183,6 +236,35 @@ public CarbonRow convert(CarbonRow row) throws CarbonDataLoadingException {
         }
       }
     }
+
+    /* If non schema fields are present, generate the value for them and convert. */
+    if (bNonSchemaPresent) {
 
 Review comment:
   Added comment in code. Also have modified converter to run the loop for 2. First iteration converts schema columns and second iteration generates and converts for non schema columns.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services