[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

[GitBox]

VenuReddy2103 commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#discussion_r373039872
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ##########
 @@ -381,7 +381,9 @@ public static boolean isHeaderValid(String tableName, String[] csvHeader,
     List<CarbonDimension> dimensions =
         schema.getCarbonTable().getDimensionByTableName(factTableName);
     for (CarbonDimension dimension : dimensions) {
-      columnNames.add(dimension.getColName());
+      if (dimension.getSchemaOrdinal() != -1) {
 
 Review comment:
   Modified. Have defined a new property to identify a column as index column instead of relying on schemaOrdinal value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services