VenuReddy2103 commented on a change in pull request #3819:
URL:
https://github.com/apache/carbondata/pull/3819#discussion_r478227905##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/utils/SDKUtil.java
##########
@@ -79,4 +98,75 @@ public static ArrayList listFiles(String sourceImageFolder,
return (Object[]) input[i];
}
+ public static List<CarbonFile> extractFilesFromFolder(String path,
+ String suf, Configuration hadoopConf) {
+ List dataFiles = listFiles(path, suf, hadoopConf);
+ List<CarbonFile> carbonFiles = new ArrayList<>();
+ for (Object dataFile: dataFiles) {
+ carbonFiles.add(FileFactory.getCarbonFile(dataFile.toString(), hadoopConf));
+ }
+ if (CollectionUtils.isEmpty(dataFiles)) {
+ throw new RuntimeException("No file found at given location. Please provide" +
+ "the correct folder location.");
+ }
+ return carbonFiles;
+ }
+
+ public static DataFileStream<GenericData.Record> buildAvroReader(CarbonFile carbonFile,
+ Configuration configuration) throws IOException {
+ try {
+ GenericDatumReader<GenericData.Record> genericDatumReader =
+ new GenericDatumReader<>();
+ DataFileStream<GenericData.Record> avroReader =
+ new DataFileStream<>(FileFactory.getDataInputStream(carbonFile.getPath(),
+ -1, configuration), genericDatumReader);
+ return avroReader;
+ } catch (FileNotFoundException ex) {
+ throw new FileNotFoundException("File " + carbonFile.getPath()
+ + " not found to build carbon writer.");
+ } catch (IOException ex) {
+ if (ex.getMessage().contains("Not a data file")) {
Review comment:
Why catch `IOException` and rethrow as `RuntimeException` here ? You converted checked exception to uncheked exception and consumed original exception completely. Better to preserve the orignal exception as there is no action after catching it except for the different exception message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
Locked
