[GitHub] [carbondata] VenuReddy2103 opened a new pull request #3524: [CARBONDATA-3519]Optimizations mentioned in Jira link CARBONDATA-3519

[GitBox]

VenuReddy2103 opened a new pull request #3524: [CARBONDATA-3519]Optimizations mentioned in Jira link CARBONDATA-3519
URL: https://github.com/apache/carbondata/pull/3524
 
 
   Be sure to do all of the following checklist to help us incorporate
   your contribution quickly and easily:
   
    - [ ] Any interfaces changed?
   No
   
    - [ ] Any backward compatibility impacted?
   No
   
    - [ ] Document update required?
   No
   
    - [ ] Testing done
           Please provide details on
           - Whether new unit test cases have been added or why no new tests are required?
           - How it is tested? Please attach test report.
           - Is it a performance related change? Please attach the performance test report.
   Yes.
           - Any additional information to help reviewers in testing this change.
         
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

VenuReddy2103 commented on issue #3524: [CARBONDATA-3519]Made optimizations in Jira link CARBONDATA-3519
URL: https://github.com/apache/carbondata/pull/3524#issuecomment-567919609
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3524: [CARBONDATA-3519]Made optimizations in Jira link CARBONDATA-3519
URL: https://github.com/apache/carbondata/pull/3524#issuecomment-567944622
 
 
   Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1230/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3524: [CARBONDATA-3519]Made optimizations in Jira link CARBONDATA-3519
URL: https://github.com/apache/carbondata/pull/3524#issuecomment-567977716
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1249/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3524: [CARBONDATA-3519]Made optimizations in Jira link CARBONDATA-3519
URL: https://github.com/apache/carbondata/pull/3524#issuecomment-567982071
 
 
   Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1240/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3524: [CARBONDATA-3519]Made optimizations in Jira link CARBONDATA-3519
URL: https://github.com/apache/carbondata/pull/3524#issuecomment-568145798
 
 
   Good to see this finding. BTW, are you observing any GC drop after the change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on issue #3524: [CARBONDATA-3519]Made optimizations in Jira link CARBONDATA-3519
URL: https://github.com/apache/carbondata/pull/3524#issuecomment-568228011
 
 
   @jackylk : This is for unsafe memory allocation, so independent of GC. But unsafe memory foot print should reduce for local dictionary string column after this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on issue #3524: [CARBONDATA-3519]Made optimizations in Jira link CARBONDATA-3519
URL: https://github.com/apache/carbondata/pull/3524#issuecomment-568228050
 
 
   LGTM
   
   @VenuReddy2103 : please update the better description
   "Multiple issue fixes in write step"
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

VenuReddy2103 commented on issue #3524: [CARBONDATA-3519]Made optimizations in Jira link CARBONDATA-3519
URL: https://github.com/apache/carbondata/pull/3524#issuecomment-568425598
 
 
   @jackylk This is for unsafe memory allocation(off heap memory with native memory allocations). Fix avoids this unnessary system memory alloc/free. Didn't measure the load performance after this change though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3524: [CARBONDATA-3519]Made optimizations in write step to avoid unnecessary memory blk allocation/free
URL: https://github.com/apache/carbondata/pull/3524#issuecomment-569379036
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3524: [CARBONDATA-3519]Made optimizations in write step to avoid unnecessary memory blk allocation/free
URL: https://github.com/apache/carbondata/pull/3524
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services