[GitHub] [carbondata] ackelcn opened a new pull request #3801: adding comments with issue numbers.

[GitBox]

ackelcn opened a new pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801


    ### Why is this PR needed?
    https://issues.apache.org/jira/browse/CARBONDATA-3866
   This issue report explains the motivation.
   
    ### What changes were proposed in this PR?
   New comments with issue numbers are added.
       
    ### Does this PR introduce any user interface change?
    - No
   NO
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
   NO
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-648585372


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-648758304


   add to whitelist


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-648759885


   @ackelcn : Its a good tool that you have.
   But inside IDE, simple annotate can tell the changes are from which PR.
   I personally feel, adding the issue ID is not good and these numbers will distract code reading. So, I think it is not required.
   
   @jackylk , @QiangCai , @kunal642 can tell you opinion on this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-648760295


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1480/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-648760641


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3206/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

chenliang613 commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-649381380


   add to whitelist


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

chenliang613 commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-649381896


   this pr is too big.  be careful to merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-649384032


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3218/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-649388349


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1491/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

QiangCai commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-650709366


   If it can help us to understand the code, we can add the issue number into the code in a few cases, else if no need to do.
   But this PR is not the above case, it added all issue numbers into code directly and didn't check whether it is needed or not.
   
   please close this PR without merging.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]