[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #2814: [CARBONDATA-3001] configurable page size in MB

[GitBox]

ajantha-bhat commented on a change in pull request #2814: [CARBONDATA-3001] configurable page size in MB
URL: https://github.com/apache/carbondata/pull/2814#discussion_r273895645
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java
 ##########
 @@ -316,31 +326,19 @@ public static CarbonFactDataHandlerModel getCarbonFactDataHandlerModel(CarbonLoa
       String[] tempStoreLocation, String carbonDataDirectoryPath) {
 
     // for dynamic page size in write step if varchar columns exist
-    List<Integer> varcharDimIdxInNoDict = new ArrayList<>();
 
 Review comment:
   It will be used for compaction also,
   getCarbonFactDataHandlerModel() is called in compaction flow, I have handled filling the datatype list in that method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services