[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #2814: [CARBONDATA-3001] configurable page size in MB

[GitBox]

ajantha-bhat commented on a change in pull request #2814: [CARBONDATA-3001] configurable page size in MB
URL: https://github.com/apache/carbondata/pull/2814#discussion_r275251624
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java
 ##########
 @@ -322,4 +325,16 @@ public void getComplexColumnInfo(List<ComplexColumnInfo> columnInfoList) {
             name, false));
     children.getComplexColumnInfo(columnInfoList);
   }
+
+  @Override
+  public int getDepth() {
+    if (depth == 0) {
+      // calculate only one time
+      List<ComplexColumnInfo> complexColumnInfoList = new ArrayList<>();
 
 Review comment:
   First time (For the first row (depth = 0), it calls `getComplexColumnInfo`, which recursively calls for child also.
   
   I am reusing the existing function instead of writing one for depth.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services