[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type

[GitBox]

ajantha-bhat commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type
URL: https://github.com/apache/carbondata/pull/3173#discussion_r275630620
 
 

 ##########
 File path: format/src/main/thrift/schema.thrift
 ##########
 @@ -33,6 +33,7 @@ enum DataType {
  TIMESTAMP = 6,
  DATE = 7,
  BOOLEAN = 8,
+ BINARY = 19,
 
 Review comment:
   Suggest to add it in the last and use value 26, not sure why this enum is not continuous.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services