[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3193: [CARBONDATA-3365] Integrate apache arrow vector filling to carbon SDK

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3193: [CARBONDATA-3365] Integrate apache arrow vector filling to carbon SDK

GitBox
ajantha-bhat commented on a change in pull request #3193: [CARBONDATA-3365] Integrate apache arrow vector filling to carbon SDK
URL: https://github.com/apache/carbondata/pull/3193#discussion_r281575680
 
 

 ##########
 File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java
 ##########
 @@ -228,4 +267,13 @@ private void validateReader() {
           " not initialise, please create it first.");
     }
   }
+
+  /**
+   * free the unsafe memory allocated , if unsafe arrow batch is used.
+   *
+   * @param address
+   */
+  public void freeArrowBatchMemory(long address) {
 
 Review comment:
   done. added in same existing testcase

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services