[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3194: [CARBONDATA-3363] SDK supports read carbon data by given file lists, file or folder

[GitBox]

ajantha-bhat commented on a change in pull request #3194: [CARBONDATA-3363] SDK supports read carbon data by given file lists, file or folder
URL: https://github.com/apache/carbondata/pull/3194#discussion_r284092880
 
 

 ##########
 File path: store/sdk/src/test/java/org/apache/carbondata/sdk/file/ImageTest.java
 ##########
 @@ -815,4 +817,214 @@ public void binaryToCarbonWithHWD(String sourceImageFolder, String outputPath, S
     reader.close();
   }
 
+  @Test
+  public void testBinaryWithFolder() throws IOException, InvalidLoadOptionException, InterruptedException {
+    int num = 1;
+    String path = "./target/flowers";
 
 Review comment:
   No need to write the data again and read it, it will slow down the PR builder,
   For existing testcase only,
   build 3 readers withFile, FileList, Folder.
   
   No need of this and below separate test case

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services