[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3197: [CARBONDATA-3367][CARBONDATA-3368] Fix multiple issues in SDK reader

[GitBox]

ajantha-bhat commented on a change in pull request #3197: [CARBONDATA-3367][CARBONDATA-3368] Fix multiple issues in SDK reader
URL: https://github.com/apache/carbondata/pull/3197#discussion_r281200549
 
 

 ##########
 File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
 ##########
 @@ -83,6 +83,21 @@ public CarbonReaderBuilder projection(String[] projectionColumnNames) {
     return this;
   }
 
+  /**
+   * Accepts projection list
+   *
+   * @param projectionColumnNames
+   * @return
+   */
+  public CarbonReaderBuilder projection(List<String> projectionColumnNames) {
 
 Review comment:
   This was also one of the issue. we need interface that accepts List. Interfacing with other languages is difficult if we use just array interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services