[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3251: [CARBONDATA-3408] CarbonSession partition support binary data type

[GitBox]

ajantha-bhat commented on a change in pull request #3251: [CARBONDATA-3408] CarbonSession partition support binary data type
URL: https://github.com/apache/carbondata/pull/3251#discussion_r291460935
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java
 ##########
 @@ -434,6 +436,10 @@ private void validateAndSetColumnCompressor(CarbonLoadModel carbonLoadModel)
 
   private void validateAndSetBinaryDecoder(CarbonLoadModel carbonLoadModel) {
     String binaryDecoder = carbonLoadModel.getBinaryDecoder();
 
 Review comment:
   If Binary decoder returns null, it throws exception ? So binary decoder becomes mandatory ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services