[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3313: [WIP]Display Job ID while executing a command.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3313: [WIP]Display Job ID while executing a command.

GitBox
ajantha-bhat commented on a change in pull request #3313: [WIP]Display Job ID while executing a command.
URL: https://github.com/apache/carbondata/pull/3313#discussion_r299404421
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
 ##########
 @@ -837,7 +836,6 @@ case class CarbonLoadDataCommand(
           query = logicalPlan,
           overwrite = false,
           ifPartitionNotExists = false)
-      sparkSession.sparkContext.setLocalProperty(EXECUTION_ID_KEY, null)
 
 Review comment:
   Old version (spark 2.2 and below , some carbon functionlities will not work if you don't set to null)
   as this change done in 2.3 spark.
   https://github.com/apache/spark/commit/9f6b3e65ccfa0daec31b58c5a6386b3a890c2149
   
   so don't set null , `if (SparkUtil.isSparkVersionXandAbove("2.3")`
   else we need to set null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services