[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3313: [WIP]Display Job ID while executing a command.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3313: [WIP]Display Job ID while executing a command.

GitBox
ajantha-bhat commented on a change in pull request #3313: [WIP]Display Job ID while executing a command.
URL: https://github.com/apache/carbondata/pull/3313#discussion_r299414100
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
 ##########
 @@ -837,7 +837,9 @@ case class CarbonLoadDataCommand(
           query = logicalPlan,
           overwrite = false,
           ifPartitionNotExists = false)
-      sparkSession.sparkContext.setLocalProperty(EXECUTION_ID_KEY, null)
+      if (!SparkUtil.isSparkVersionXandAbove("2.3")) {
+        sparkSession.sparkContext.setLocalProperty(EXECUTION_ID_KEY, null)
 
 Review comment:
   Add a comment in all the 3 places about why this change is done.
   
   `"spark.sql.execution.id is already set" exception will be thrown if not set to null in spark2.2 and below versions`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services