[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3324: [HOTFIX] Fix task id in FileFormat write

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3324: [HOTFIX] Fix task id in FileFormat write

GitBox
ajantha-bhat commented on a change in pull request #3324: [HOTFIX] Fix task id in FileFormat write
URL: https://github.com/apache/carbondata/pull/3324#discussion_r303195094
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/CarbonThreadFactory.java
 ##########
 @@ -49,7 +49,7 @@ public CarbonThreadFactory(String name, boolean withTime) {
   @Override public Thread newThread(Runnable r) {
     final Thread thread = defaultFactory.newThread(r);
     if (withTime) {
-      thread.setName(name + "_" + System.currentTimeMillis());
+      thread.setName(name + "_" + System.nanoTime());
 
 Review comment:
   I just made it more accurate by changing from milli to nano.
   
   This is not directly linked with spark task number so cannot use it here, This thread pool is used internally in many places.
   I will analyse and handle in other PR if required.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services